Extract the ConnectionListener creation in a separate method in Pool

eclipse-vertx · May 25, 2018 · a4d13b6 · a4d13b6
1 parent 1bb6445
commit a4d13b6
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/src/main/java/io/vertx/core/http/impl/pool/Pool.java b/src/main/java/io/vertx/core/http/impl/pool/Pool.java
@@ -237,9 +237,8 @@ private void checkPending() {
     }
   }
 
-  private void createConnection(Waiter<C> waiter) {
-    Holder<C> holder  = new Holder<>();
-    ConnectionListener<C> listener = new ConnectionListener<C>() {
+  private ConnectionListener<C> createListener(Holder<C> holder) {
+    return new ConnectionListener<C>() {
       @Override
       public void onConcurrencyChange(long concurrency) {
         synchronized (Pool.this) {
@@ -259,6 +258,7 @@ public void onConcurrencyChange(long concurrency) {
           }
         }
       }
+
       @Override
       public void onRecycle(long expirationTimestamp) {
         if (expirationTimestamp < 0L) {
@@ -271,6 +271,7 @@ public void onRecycle(long expirationTimestamp) {
           recycle(holder, 1, expirationTimestamp);
         }
       }
+
       @Override
       public void onDiscard() {
         synchronized (Pool.this) {
@@ -281,6 +282,11 @@ public void onDiscard() {
         }
       }
     };
+  }
+
+  private void createConnection(Waiter<C> waiter) {
+    Holder<C> holder  = new Holder<>();
+    ConnectionListener<C> listener = createListener(holder);
     connector.connect(listener, waiter.context, ar -> {
       if (ar.succeeded()) {
         ConnectResult<C> result = ar.result();