Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default command specified in Main-Command MANIFEST entry not run if no Main-Verticle entry #1346

Closed
Megaprog opened this issue Mar 23, 2016 · 1 comment
Closed

Default command specified in Main-Command MANIFEST entry not run if no Main-Verticle entry #1346

Megaprog opened this issue Mar 23, 2016 · 1 comment

Comments

@Megaprog
Copy link

Vext.x version 3.2.1

In VerxCommandLauncher line 378 there is check for verticle != null only then getDefaultCommand() executed. But may be we not needed any vehicles in manifest at all.
@cescoffier
Copy link
Contributor

Agreed this is a bug.

cescoffier added a commit to cescoffier/vert.x that referenced this issue Mar 29, 2016
@cescoffier
Fix eclipse-vertx#1346
888aad4 
Execute the command specified in the manifest if set and not overriden in the command line.

Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>
@cescoffier cescoffier mentioned this issue Mar 29, 2016
Merged
@cescoffier cescoffier mentioned this issue Mar 29, 2016
Merged
@vietj vietj closed this as completed in 5f5e65e Apr 8, 2016
vietj added a commit that referenced this issue Apr 11, 2016
@vietj
Merge remote-tracking branch 'clement/issues/#1346-default-command-in…
bd1cf03 
…-manifest'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cescoffier @Megaprog