Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TrustOptions and KeyCertOptions should define a copy() method instead of clone() #2833

Closed
vietj opened this issue Feb 16, 2019 · 1 comment
Closed

TrustOptions and KeyCertOptions should define a copy() method instead of clone() #2833

vietj opened this issue Feb 16, 2019 · 1 comment
Assignees
@vietj
Labels
deprecation enhancement
Milestone
3.7.0

Comments

@vietj
Copy link
Member

vietj commented Feb 16, 2019 •
edited

Currently TrustOptions and KeyCertOptions interface defines a clone() method without extending the Cloneable interface. The method should be deprecated in 3.x with a new copy() method and the copy() method should delegate to the clone() method as default implementation. The clone() method is removed in 4.0.

This method is not intended to be used by developers, usually it is used internally when an options object is copied and this is used to implement a polymorphic copy.
@vietj vietj added this to the 3.7.0 milestone Feb 16, 2019
@vietj vietj self-assigned this Feb 16, 2019
vietj added a commit that referenced this issue Feb 16, 2019
@vietj
TrustOptions and KeyCertOptions should define a copy() method instead…
5fcfb48 
… of clone() - fixes #2833
@vietj
Copy link
Member Author

vietj commented Feb 16, 2019

see vert-x3/issues#363

@vietj vietj closed this as completed Feb 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vietj vietj

Labels
deprecation enhancement
Projects
None yet
Milestone
3.7.0
Development

No branches or pull requests
1 participant
@vietj