Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSocket API renaming #3234

Closed
vietj opened this issue Dec 18, 2019 · 0 comments
Closed

WebSocket API renaming #3234

vietj opened this issue Dec 18, 2019 · 0 comments
Assignees
Milestone

Comments

@vietj
Copy link
Member

vietj commented Dec 18, 2019

Vert.x 3.x provides an inconsistent naming concerning for WebSocket, it is often spelled as Websocket. We should address this in Vert.x 4 whenever possible and provide deprecation for incorrect names.

We can fix all of them but the WebsocketVersion that would be breaking. In 3.x we provide deprecations along with correctly spelled equivalents:

  • HttpServerOptions properties
    • spelling fixes
    • the fixed sub-protocols uses now List<String> instead of a coma separated string
  • HttpClientOptions properties
  • HttpServer handlers (websocketHandler, websocketStream)
  • WebsocketRejectedException now extends the more generic UpgradeRejectedException
@vietj vietj added this to the 3.8.5 milestone Dec 18, 2019
@vietj vietj self-assigned this Dec 18, 2019
vietj added a commit that referenced this issue Dec 18, 2019
@vietj vietj closed this as completed Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant