Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster public props #1118

Merged
merged 2 commits into from Sep 4, 2015
Merged

Cluster public props #1118

merged 2 commits into from Sep 4, 2015

Conversation

purplefox
Copy link
Contributor

@cescoffier @pmlopes please review.

@cescoffier
Copy link
Contributor

I wonder if we should we add a parameter to Starter to configure the public host / port ? We can use the system property mapping for this, so it's not required.

Except that, +1.

@pmlopes
Copy link
Contributor

pmlopes commented Sep 4, 2015

👍

purplefox added a commit that referenced this pull request Sep 4, 2015
@purplefox purplefox merged commit aaf80ae into master Sep 4, 2015
@vietj vietj deleted the cluster_public_props branch May 14, 2018 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants