Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automatic module name #3401

Merged
merged 1 commit into from
May 14, 2020
Merged

Add automatic module name #3401

merged 1 commit into from
May 14, 2020

Conversation

afloarea
Copy link
Contributor

@afloarea afloarea commented May 6, 2020

Signed-off-by: afloarea adrianfloarea07@yahoo.com

Motivation:

Add automatic module name as per issue #524

@vietj
Copy link
Member

vietj commented May 7, 2020

I woiuld like first to see if we can do something in the vertx-parent pom

@vietj
Copy link
Member

vietj commented May 7, 2020

@afloarea please have a look at vert-x3/vertx-parent@1384372

This change should allow to have a file named MANIFEST.MF that will contain the entry containing Automatic-Module-Name: io.vertx.core that will define the automatic module name.

pom.xml Outdated Show resolved Hide resolved
Signed-off-by: afloarea <adrianfloarea07@yahoo.com>
@vietj vietj merged commit 22ce191 into eclipse-vertx:master May 14, 2020
@vietj vietj added this to the 4.0.0 milestone May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants