Add option for whether semicolon is treated as normal character or not

[PragmaTwice]

Motivation:

Close #4588.

This PR adds an option uriQuerySemicolonIsNormalChar to HttpServerOptions to support treating ; a normal character instead of query parameter seperator, since it has already been supported in netty QueryStringDecoder.

And the default behavior is still to treat ; as a seperator to ensure compatibility.

References:

• Support semicolons in query parameters as explain in the W3C recommen… netty/netty#9701
• https://stackoverflow.com/questions/3481664/semicolon-as-url-query-separator

Conformance:

You should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md

Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines

[vietj]

I don't think we are going to make this an option as it is very specific to the API and not related to the behavior of the HTTP server itself

[vietj]

Instead it should be a method parameter of Http1xServerRequest#params() method

[vietj]

Use a method parameter instead of an HTTP server option

[PragmaTwice]

Use a method parameter instead of an HTTP server option

Done according to your suggestions : )

Feel free to review again and comment. @vietj

[vietj]

since the created multimap is cached, we should also cache the delimiter and check the delimiter is the same when accessing again the multimap because this might be called multiple times with different values, when the delimiter is not the same then we should compute it again (and perhaps cache it).

[PragmaTwice]

since the created multimap is cached, we should also cache the delimiter and check the delimiter is the same when accessing again the multimap because this might be called multiple times with different values, when the delimiter is not the same then we should compute it again (and perhaps cache it).

Thank you ! I see.

I've added a new cached property semicolonIsNormalCharInParams and use it to check if the cached params need to be refreshed.

Please review it again : )

[PragmaTwice]

Fixed according to your suggestions : )

Feel free to review again and comment. cc @vietj

[vietj]

This test only the new feature with HTTP/2, a new test should be added in HttpTest so it will be executed for for HTTP/2 and HTTP/1.

[PragmaTwice]

Fixed according to your suggestions : )

Feel free to review again and comment. cc @vietj

[PragmaTwice]

Fixed according to your suggestions : )

Feel free to review again and comment. cc @vietj

[vietj]

Can you squash everything in a single commit to facilitate back-port to 4.x ?

[PragmaTwice]

Can you squash everything in a single commit to facilitate back-port to 4.x ?

Done. Please check.

[vietj]

thanks I'll merge that soon and backport