Fix json object/array BigInteger/BidDecimal value comparison #5236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly compare BigInteger/BigDecimal values. Fix this issue and also simplify / refactor this code to be more compact and reused between object/array
vietj
force-pushed
the
fix-json-numeric-value-comparison-bug
branch
from
fa4f4d4
to
0d5b88f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code to compare two numbers in json object/array does not correctly compare BigInteger/BigDecimal values.
Fix this issue and also simplify / refactor this code to be more compact and reused between object/array