Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split package removal #679

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Split package removal #679

merged 2 commits into from
Jun 14, 2024

Conversation

vietj
Copy link
Member

@vietj vietj commented Jun 14, 2024

The package vertx-auth-common contains a few types in the io.vertx.ext.auth package which creates a split package situation, preventing the vertx-auth project to support JPMS.

This changes the packages of those classes, allowing an eventual JPMS support.

The refactored types are:

  • io.vertx.ext.auth.HashingStrategy → io.vertx.ext.auth.hashing.HashinStrategy
  • io.vertx.ext.auth.HashingAlgorithm → io.vertx.ext.auth.hashing.HashingAlgorithm
  • io.vertx.ext.auth.ChainAuth → io.vertx.ext.auth.chain.ChainAuth
  • io.vertx.ext.auth.JWTOptions → io.vertx.ext.auth.jose.JWTOptions
  • io.vertx.ext.auth.KeyStoreOptions → io.vertx.ext.auth.jose.KeyStoreOptions
  • io.vertx.ext.auth.NoSuchKeyIdException → io.vertx.ext.auth.jose.NoSuchKeyIdException
  • io.vertx.ext.auth.PubSecKeyOptions → io.vertx.ext.auth.jose.PubSecKeyOptions
  • io.vertx.ext.auth.PRNG → io.vertx.ext.auth.prng.PRNG
  • io.vertx.ext.auth.VertxContextPRNG → io.vertx.ext.auth.prng.VertxContextPRNG
  • io.vertx.ext.auth.User→ io.vertx.ext.auth.user.User

@vietj vietj added this to the 5.0.0 milestone Jun 14, 2024
@vietj vietj marked this pull request as draft June 14, 2024 12:20
….ext.auth` package which creates a split package situation, preventing the vertx-auth project to support JPMS.

This changes the packages of those classes, allowing an eventual JPMS support.

The refactored types are:

- io.vertx.ext.auth.HashingStrategy → io.vertx.ext.auth.hashing.HashinStrategy
- io.vertx.ext.auth.HashingAlgorithm → io.vertx.ext.auth.hashing.HashingAlgorithm
- io.vertx.ext.auth.ChainAuth → io.vertx.ext.auth.chain.ChainAuth
- io.vertx.ext.auth.JWTOptions → io.vertx.ext.auth.jose.JWTOptions
- io.vertx.ext.auth.KeyStoreOptions → io.vertx.ext.auth.jose.KeyStoreOptions
- io.vertx.ext.auth.NoSuchKeyIdException → io.vertx.ext.auth.jose.NoSuchKeyIdException
- io.vertx.ext.auth.PubSecKeyOptions → io.vertx.ext.auth.jose.PubSecKeyOptions
- io.vertx.ext.auth.PRNG → io.vertx.ext.auth.prng.PRNG
- io.vertx.ext.auth.VertxContextPRNG → io.vertx.ext.auth.prng.VertxContextPRNG
- io.vertx.ext.auth.User→ io.vertx.ext.auth.user.User
@vietj vietj marked this pull request as ready for review June 14, 2024 18:28
@vietj vietj merged commit a179495 into master Jun 14, 2024
6 checks passed
@vietj vietj deleted the split-package-removal branch June 14, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant