JPMS support #386
Merged
JPMS support #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vertx-codegen-api declares its own module descriptor. vertx-codegen-processor and vertx-codegen-json instead rely on moditect to generate descriptor for the sake of preserving the execution of codegen processor tests in IDE. The codegen processor is not intended to be modular, however vertx-codegen-api and vertx-codegen-json are actually consumed by from java modules (e.g io.vertx.core module). the absence of an module-info descriptor instructs the IDE to run tests in classpath mode which is exactly what we need, hence the use of moditect for such trivial case.
This was referenced Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vertx-codegen-api declares its own module descriptor as a
module-info.javafile.The vertx-codegen-processor and vertx-codegen-json modules instead rely on moditect to generate module descriptor for the sake of preserving the execution of codegen processor tests in IDE. The codegen processor is not intended to be modular, however vertx-codegen-api and vertx-codegen-json are actually consumed by from java modules (e.g
io.vertx.coremodule).The absence of an module-info descriptor instructs the IDE to run tests in classpath mode which is what we need, hence the moditect is a good fit.