-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GrpcServer can't be mounted in a Vert.x Web router #84
Labels
Milestone
Comments
@vietj did I miss anything? |
tsegismont
added a commit
to tsegismont/vertx-grpc
that referenced
this issue
Jan 3, 2024
Fixes eclipse-vertx#84 In order to integrate Vert.x Web routes and gRPC servers, we need an adapter. Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont
added a commit
to tsegismont/vertx-grpc
that referenced
this issue
Jan 3, 2024
See eclipse-vertx#84 In order to integrate Vert.x Web routes and gRPC servers, we need an adapter. Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
I would like to avoid this dependency of vertx-grpc over vertx-web for various reasons. Instead we should provide the code |
OK, let's fix the documentation and the blog post |
tsegismont
added a commit
to tsegismont/vertx-grpc
that referenced
this issue
Jan 11, 2024
See eclipse-vertx#84 Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont
added a commit
to tsegismont/vertx-grpc
that referenced
this issue
Jan 11, 2024
See eclipse-vertx#84 Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
vietj
pushed a commit
that referenced
this issue
Jan 19, 2024
See #84 Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont
added a commit
that referenced
this issue
Jan 19, 2024
See #84 Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
Fixed by 31d21d8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
The documentation and the 4.3 release blog post indicate that a
GrpcServer
can be mounted in a Vert.x Web router.In fact, it is not possible because the gRPC server is a
Handler<HttpServerRequest>
not aHandler<RoutingContext>
. So this blog post example is wrong:The text was updated successfully, but these errors were encountered: