Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable from interceptor to originSelector #35

Open
zenios opened this issue Apr 19, 2022 · 3 comments
Open

Variable from interceptor to originSelector #35

zenios opened this issue Apr 19, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@zenios
Copy link

zenios commented Apr 19, 2022

Sometimes we might want to assign a variable inside an interceptor that will help the origin selector to decide the actual origin. What is the optimal way to do these as of now. I searched and could not find anything

@zenios zenios added the enhancement New feature or request label Apr 19, 2022
@dinstone
Copy link

This is really a good question. I think setting the origin selector to return request options can solve the problem.
originSelector(Function<HttpServerRequest, Future<RequestOptions>> selector)

@vietj
Copy link
Member

vietj commented Nov 15, 2022

I think we could resolve the origin server before the interceptors kick-in and then it would be exposed in the ProxyContext and can be overriden, or something like that .

@vietj
Copy link
Member

vietj commented Feb 17, 2023

sometimes the ProxyContext is not available for a resolution, e.g in the WebSocket case, so we need to come with an interface that provides similar info for this case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants