Skip to content

Commit

Permalink
Fix issues (#3)
Browse files Browse the repository at this point in the history
* Fix build badge

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>

* Disable tests that fail until Vert.x core is merged

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>

---------

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
  • Loading branch information
tsegismont committed Jul 31, 2023
1 parent ff55773 commit 017bf1d
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
2 changes: 1 addition & 1 deletion README.adoc
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
= Vert.x Application Launcher

image:https://github.com/vert-x3/vertx-launcher/actions/workflows/ci-5.x.yml/badge.svg["Build Status (5.x)",link="https://github.com/vert-x3/vertx-launcher/actions/workflows/ci-5.x.yml"]
image:https://github.com/eclipse-vertx/vertx-launcher/actions/workflows/ci-5.x.yml/badge.svg["Build Status (5.x)",link="https://github.com/eclipse-vertx/vertx-launcher/actions/workflows/ci-5.x.yml"]

In essence, launching a Vert.x application is not a complex task: write a class with a `main` method, create a Vert.x instance and deploy the main verticle.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
import io.vertx.test.verticles.TestVerticle;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.io.TempDir;

Expand Down Expand Up @@ -269,11 +270,13 @@ public void beforeStartingVertx(HookContext context) {
}

@Test
@Disabled("until Vert.x core PR is merged")
public void testConfigureFromSystemProperties() {
testConfigureFromSystemProperties(false);
}

@Test
@Disabled("until Vert.x core PR is merged")
public void testConfigureFromSystemPropertiesClustered() {
testConfigureFromSystemProperties(true);
}
Expand Down Expand Up @@ -334,6 +337,7 @@ private void clearProperties() {
}

@Test
@Disabled("until Vert.x core PR is merged")
public void testCustomMetricsOptions() {
AtomicReference<VertxOptions> vertxOptions = new AtomicReference<>();
hooks = new TestHooks() {
Expand Down

0 comments on commit 017bf1d

Please sign in to comment.