Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect implementation of tuple factory method #400

Closed
BillyYccc opened this issue Aug 23, 2019 · 4 comments
Closed

Incorrect implementation of tuple factory method #400

BillyYccc opened this issue Aug 23, 2019 · 4 comments
Assignees
Labels
Milestone

Comments

@BillyYccc
Copy link
Member

/**
* Create a tuple of six elements.
*
* @param elements the list of elements
* @return the tuple
*/
static Tuple tuple(List<Object> elements) {
ArrayTuple tuple = new ArrayTuple(5);
return tuple;
}

@BillyYccc
Copy link
Member Author

Tuple built from List method does not work

@zhbotong
Copy link
Contributor

why six elements.... if elements size more than six?

@BillyYccc
Copy link
Member Author

BillyYccc commented Aug 23, 2019 via email

@vietj
Copy link
Member

vietj commented Aug 24, 2019

yes this is a bug, in the mean time people can use the new Tuple.wrap(list) method

@vietj vietj closed this as completed in 445c78d Aug 24, 2019
@vietj vietj added this to the 3.8.2 milestone Aug 24, 2019
@vietj vietj added the bug label Aug 24, 2019
@vietj vietj self-assigned this Aug 24, 2019
BillyYccc pushed a commit to BillyYccc/vertx-sql-client that referenced this issue Aug 30, 2019
jeoffreylim pushed a commit to jeoffreylim/vertx-sql-client that referenced this issue Sep 12, 2019
…x#400

Signed-off-by: Jeoffrey Lim <jeoffreyl@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants