PreparedStatement bicommand scheduling on pool are not scheduled on the same connection

[BillyYccc]

Version

this should happen in 3.9 version

Context

We meet such exceptions when we use SqlClient#preparedQuery

o.vertx.mysqlclient.MySQLException: Unknown prepared statement handler (1) given to mysqld_stmt_execute
	at io.vertx.mysqlclient.impl.codec.CommandCodec.handleErrorPacketPayload(CommandCodec.java:131)
	at io.vertx.mysqlclient.impl.codec.ExtendedQueryCommandBaseCodec.handleInitPacket(ExtendedQueryCommandBaseCodec.java:28)
	at io.vertx.mysqlclient.impl.codec.QueryCommandBaseCodec.decodePayload(QueryCommandBaseCodec.java:58)
	at io.vertx.mysqlclient.impl.codec.ExtendedQueryCommandCodec.decodePayload(ExtendedQueryCommandCodec.java:100)
	at io.vertx.mysqlclient.impl.codec.MySQLDecoder.decodePacket(MySQLDecoder.java:65)
	at io.vertx.mysqlclient.impl.codec.MySQLDecoder.decode(MySQLDecoder.java:54)
	at io.netty.handler.codec.ByteToMessageDecoder.decodeRemovalReentryProtection(ByteToMessageDecoder.java:498)
	at io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:437)
	at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:276)
	at io.netty.channel.CombinedChannelDuplexHandler.channelRead(CombinedChannelDuplexHandler.java:251)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
	at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
	at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919)
	at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:163)
	at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:714)
	at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:650)
	at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:576)
	at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:493)
	at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:989)
	at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
	at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
	at java.lang.Thread.run(Thread.java:748)

One-shot prepared statement executing will schedule a PrepareStatementCommand and ExtendedQueryCommand like this

vertx-sql-client/vertx-sql-client/src/main/java/io/vertx/sqlclient/impl/SqlClientBase.java

Lines 100 to 116 in f449803

	@Override
	public void execute(Tuple arguments, Handler<AsyncResult<R>> handler) {
	SqlResultHandler resultHandler = builder.createHandler(handler);
	schedule(new PrepareStatementCommand(sql), cr -> {
	if (cr.succeeded()) {
	PreparedStatement ps = cr.result();
	String msg = ps.prepare((TupleInternal) arguments);
	if (msg != null) {
	handler.handle(Future.failedFuture(msg));
	} else {
	schedule(builder.createExtendedQuery(ps, arguments, resultHandler), resultHandler);
	}
	} else {
	handler.handle(Future.failedFuture(cr.cause()));
	}
	});
	}

such two commands may be scheduled on the different connections acquired from the pool, we should make sure the BiCommand scheduling happen on the same session

Do you have a reproducer?

see https://groups.google.com/forum/?fromgroups#!topic/vertx/KAdcC_yNG8E
This also happens in https://travis-ci.org/github/eclipse-vertx/vertx-sql-client/jobs/674432633

A simple snippet of code could reproduce this

// set pool size to 2
  @Test
  public void highContendPreparedQuery(TestContext ctx) {
    Async async = ctx.async(15000);
    for (int i = 0; i < 15000; i++) {
      pool.preparedQuery("SELECT " + i).execute(ctx.asyncAssertSuccess(res -> {
        async.countDown();
      }));
    }
    async.await();
  }

[vietj]

did you work on this issue @BillyYccc ?

[BillyYccc]

not yet, but I hope we can settle this in 3.9.1 Julien Viet <notifications@github.com> 于 2020年5月11日周一 18:44写道：

…

did you work on this issue @BillyYccc <https://github.com/BillyYccc> ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#590 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABJV4JORA467D76J3C46N2TRQ7JJVANCNFSM4MHARZBQ> .

[vietj]

Any chance by tomorrow ?

…

On 11 May 2020, at 12:50, Billy Yuan ***@***.***> wrote: not yet, but I hope we can settle this in 3.9.1 Julien Viet ***@***.***> 于 2020年5月11日周一 18:44写道： > did you work on this issue @BillyYccc <https://github.com/BillyYccc> ? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#590 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ABJV4JORA467D76J3C46N2TRQ7JJVANCNFSM4MHARZBQ> > . > — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#590 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABXDCTXYHVTJ6BOMBQNM53RQ7J6RANCNFSM4MHARZBQ>.

[BillyYccc]

I'll hava a try tonight Julien Viet <notifications@github.com> 于 2020年5月11日周一 19:21写道：

…

Any chance by tomorrow ? > On 11 May 2020, at 12:50, Billy Yuan ***@***.***> wrote: > > > not yet, but I hope we can settle this in 3.9.1 > > Julien Viet ***@***.***> 于 2020年5月11日周一 18:44写道： > > > did you work on this issue @BillyYccc <https://github.com/BillyYccc> ? > > > > — > > You are receiving this because you were mentioned. > > Reply to this email directly, view it on GitHub > > < #590 (comment) >, > > or unsubscribe > > < https://github.com/notifications/unsubscribe-auth/ABJV4JORA467D76J3C46N2TRQ7JJVANCNFSM4MHARZBQ > > > . > > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub < #590 (comment)>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AABXDCTXYHVTJ6BOMBQNM53RQ7J6RANCNFSM4MHARZBQ >. > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#590 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABJV4JKSLWKFF4CIRCD2KR3RQ7NTNANCNFSM4MHARZBQ> .

[vietj]

I will handle this one @BillyYccc

[vietj]

funny there is already such similar test in PgPoolTest

[vietj]

the fix is easy, I'm almost done with it. I'll port the test to master as well.