Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle NUMERIC type with a custom Number #70

Closed
vietj opened this issue Mar 8, 2018 · 0 comments
Closed

Handle NUMERIC type with a custom Number #70

vietj opened this issue Mar 8, 2018 · 0 comments
Milestone
0.6.0

Comments

@vietj
Copy link
Member

vietj commented Mar 8, 2018

motivation: currently NUMERIC type is mapped to BigDecimal which does not allow a full representability of the type (such as ∞).
changes: provide a specific subclass of Number (perhaps named PgNumeric ?) that wraps the value as a BigDecimal when possible otherwise indicates which specific value it is. This can then be converted by the Row class to other values or can be retrieved as is. This mapping shall be bidirectional.
@vietj vietj mentioned this issue Mar 8, 2018
Closed
@vietj vietj added this to the 0.6.0 milestone Mar 8, 2018
vietj added a commit that referenced this issue Mar 9, 2018
@vietj
Handle NUMERIC type with a custom Number - fixes #70
f2836c6
@vietj vietj closed this as completed in 91a632f Mar 16, 2018
vietj added a commit that referenced this issue Mar 16, 2018
@vietj
Merge pull request #71 from vietj/numeric-type
8db2c4c 
Handle NUMERIC type with a custom Number - fixes #70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.0
Development

No branches or pull requests
1 participant
@vietj