Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Postgres resultset metadata and column metadata support #513

Conversation

BillyYccc
Copy link
Member

Motivation:

Users can get the metadata of columns and resultset now - fixes #470.

Signed-off-by: Billy Yuan <billy112487983@gmail.com>
Signed-off-by: Billy Yuan <billy112487983@gmail.com>
@BillyYccc BillyYccc requested a review from vietj February 3, 2020 15:33
@BillyYccc
Copy link
Member Author

@vietj can you please take a look at this?

@BillyYccc BillyYccc added this to the 4.0.0 milestone Feb 3, 2020
@vietj
Copy link
Member

vietj commented Feb 5, 2020

is there a pressing need for this ? I would like to study how we can do that for all clients, i.e do we need a same API for all databases ?

@BillyYccc
Copy link
Member Author

That means we need to build an abstraction to describe resultset metadata but the information provided by various vendor database servers is so different that it's hard to cover all the cases using a unified API.

@aguibert
Copy link
Member

@vietj There is now a moderate need for this item. Hibernate Reactive needs some sort of metadata similar to what JDBC metadata offers in order to perform the full set of schema management operations.

+1 that we should consider this at a generic API level though. This feature would only be useful to Hibernate Reactive if it were a generic API, in the current form (PG only) it wouldn't be easily usable by upstack libs.

@gavinking
Copy link

Hibernate Reactive needs some sort of metadata similar to what JDBC metadata offers in order to perform the full set of schema management operations.

Well, wait. It looks like this issue refers to result set metadata. That's not what Hibernate schema management uses. What it uses is table metadata (information schema).

@vietj vietj closed this Sep 28, 2020
@vietj vietj removed this from the 4.0.0 milestone Sep 28, 2020
@vietj
Copy link
Member

vietj commented Sep 28, 2020

closing this as now we have Columndescritpor in master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Postgres]Provide access to resultset metadata
4 participants