Support for sampling in Vertx

[nitishgoyal13]

Describe the feature

Ability to sample requests passing through vert.x application

[nitishgoyal13]

@vietj Is it possible for you to kindly provide an update on this? It's a blocker for us to start using zipkin with vert.x

[vietj]

can you elaborate on this feature and give more information ?

[vietj]

I set to 4.0.1 as fix date to ensure it does not get forgotten

[nitishgoyal13]

I meant that Sampling option inside ZipkinTracingOptions is hard coded to Sampler.ALWAYS_SAMPLE
I feel, we should provide the application an ability to supply Sampler from outside so that all sampling options supported by Brave can be used in ZipkinTracingOptions

[vietj]

Sure we can do that, do you mind doing a contribution for this ?

…

On Fri, Jan 8, 2021 at 3:18 AM Nitish Goyal ***@***.***> wrote: I meant that Sampling option inside ZipkinTracingOptions is hard coded to Sampler.ALWAYS_SAMPLE I feel, we should provide the application an ability to supply Sampler from outside so that all sampling options supported by Brave can be used in ZipkinTracingOptions — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#15 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABXDCVEBYQTVNBDMMZLYTTSYZTN3ANCNFSM4VARK2JA> .

[tsegismont]

Closed in 03d5753