Fix for issue #150. Port vctl --all-tagged from monolithic code #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craig8
reviewed
Feb 1, 2023
| start_agent(opts) | ||
|
|
||
|
|
||
| def act_on_agent(action, opts): |
There was a problem hiding this comment.
Please document the new "act_on_agent" function now including what is expected in opts and how this method works.
craig8
reviewed
Feb 1, 2023
| @@ -145,13 +145,13 @@ def escape(pattern): | |||
|
|
|||
|
|
|||
| def filter_agents(agents, patterns, opts): | |||
There was a problem hiding this comment.
Please document the filter_agents method to have the different options be called out in the docs.
craig8
reviewed
Feb 1, 2023
| if pid and status is None: | ||
| _stdout.write(f"Stopping {agent.uuid} {agent.name}\n") | ||
| call(action, agent.uuid) | ||
| return | ||
|
|
||
|
|
||
| def run_agent(opts): |
There was a problem hiding this comment.
Please document the run_agent(opts) method
|
without the platform running I think you should be able to get a help from vctl not sure if we can separate all of the commands out but the top level should work? This might be a different issue to be made though. |
|
Created new issue #155 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #150 - port vctl --all-tagged from monolithic code (https://github.com/VOLTTRON/volttron/pull/2882/files)