Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle resource instances in Read, Write, and Observe. #435

Merged
merged 8 commits into from Nov 20, 2020

Conversation

sbertin-telular
Copy link
Contributor

Implements partial updates in writes as that was needed to handle the resource instances without major API changes.
Also fixes several issues found that impacted implementation and/or testing.

Contains an alternate fix to #396.

@sbertin-telular
Copy link
Contributor Author

Rebased. I didn't think squashing made sense. @rettichschnidi please review.
It looks like the build is failing because the repository for the tinydtls submodule is no longer there, It seems to have been relocated to GitHub (https://github.com/eclipse/tinydtls). I'm looking into how to update that.

@sbertin-telular
Copy link
Contributor Author

#496 fixes the location of tinydtls, but there is another build problem. I'll rebase again once the build is fixed.

Signed-off-by: Scott Bertin <sbertin@telular.com>
Signed-off-by: Scott Bertin <sbertin@telular.com>
Fix problem serializing resource instance reads.
Fix handling of empty strings and opaque.
Fix JSON serializing single instance resource as multiple. Fixes eclipse-wakaama#378.
Fix JSON parsing of multiple instance resources. Fixes eclipse-wakaama#399.

Signed-off-by: Scott Bertin <sbertin@telular.com>
Signed-off-by: Scott Bertin <sbertin@telular.com>
Signed-off-by: Scott Bertin <sbertin@telular.com>
Fixes eclipse-wakaama#332 and prepares for writes of individual resource instances.

Signed-off-by: Scott Bertin <sbertin@telular.com>
Signed-off-by: Scott Bertin <sbertin@telular.com>
Signed-off-by: Scott Bertin <sbertin@telular.com>
@sbertin-telular
Copy link
Contributor Author

Rebased again.

@rettichschnidi
Copy link
Contributor

rettichschnidi commented Nov 19, 2020

@sbertin-telular I am busy with other stuff right now, but @qleisan committed to give feedback.

@qleisan
Copy link

qleisan commented Nov 19, 2020

I have reviewed the commits and "looks good to me". However I can only do a "lighter review" at this time since I'm still getting into the project/codebase.

@sbernard31
Copy link
Contributor

sbernard31 commented Nov 19, 2020

I suppose this means that I can integrate those commits ? (or there are more review planned ?)

@qleisan
Copy link

qleisan commented Nov 19, 2020

In my opinion yes. @sbertin-telular, ok for you?

@sbertin-telular
Copy link
Contributor Author

@sbernard31 go ahead and merge.

@sbernard31 sbernard31 merged commit 68b6c49 into eclipse-wakaama:master Nov 20, 2020
@sbernard31
Copy link
Contributor

Done.

@sbertin-telular, regarding your comment :

Contains an alternate fix to #396.

Should we close #396 ?

@sbertin-telular
Copy link
Contributor Author

@sbernard31 Yes, I think we should close #396.

@sbernard31
Copy link
Contributor

@sbertin-telular and #437 too ? (regarding #437 (comment))

@sbertin-telular
Copy link
Contributor Author

Yes, #437 too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants