Improve coding style #543
Merged
Improve coding style #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make explicit comparison with NULL to address reported issue eclipse-wakaama#499. Not a bug. Signed-off-by: Leif Sandstrom <leif.sandstrom@husqvarnagroup.com>
|
(forgot to sign off commit first time) |
| @@ -276,7 +276,7 @@ static bool prv_convertValue(_record_t * recordP, | |||
| { | |||
| size_t stringLen; | |||
| uint8_t *string = (uint8_t *)lwm2m_malloc(recordP->valueLen); | |||
| if (!string) return false; | |||
| if (string == NULL) return false; | |||
| stringLen = json_unescapeString(string, recordP->value, recordP->valueLen); | |||
| if (stringLen) | |||
There was a problem hiding this comment.
If a NULL comparison for string is added, shouldn't there also be a comparison to 0 for stringLen?
There was a problem hiding this comment.
No check is really added, only rewritten if(!string) <=> if (string == NULL) to accommodate #499 concern about "using string as a boolean". I felt it was right to align to the dominating coding style of comparing with NULL.
I see your point but the coding style in the code is more explicit when checking pointers, I believe. Your input on #513 is appreciated
sbertin-telular
approved these changes
Feb 22, 2021
tuve
approved these changes
Feb 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make explicit comparison with NULL to address reported issue #499. Not a bug
Closes #499