Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Integrate SonarCloud #573

Merged
merged 5 commits into from
Apr 20, 2021
Merged

ci: Integrate SonarCloud #573

merged 5 commits into from
Apr 20, 2021

Commits on Apr 20, 2021

  1. ci: Integrate SonarCloud 

    This will give us details coverage and static and static code analysis
for every push.

To enable the integration, take the following steps:
 - Log in to https://sonarcloud.io/ using your GitHub account
 - Visit https://sonarcloud.io/projects/create, add Wakaama (fairly
   self-explanatory)
 - Create a PR in your repository to verify the integration

PRs do not get checked because it is tricky to do it in a secure
fashion:
 - https://jira.sonarsource.com/browse/MMF-1371
 - https://securitylab.github.com/research/github-actions-preventing-pwn-requests/

Signed-off-by: Reto Schneider <code@reto-schneider.ch>
    @rettichschnidi
    rettichschnidi committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    fa457ce View commit details
    Browse the repository at this point in the history

  2. fixup! ci: Integrate SonarCloud

    @rettichschnidi
    rettichschnidi committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    bd2fb38 View commit details
    Browse the repository at this point in the history

  3. Remove superfluous semicolon 

    Found by SonarCloud.

Signed-off-by: Reto Schneider <code@reto-schneider.ch>
    @rettichschnidi
    rettichschnidi committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    97fa3d0 View commit details
    Browse the repository at this point in the history

  4. Specify HTML document language 

    SonarCloud has complained before.

Signed-off-by: Reto Schneider <code@reto-schneider.ch>
    @rettichschnidi
    rettichschnidi committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    c66507a View commit details
    Browse the repository at this point in the history

  5. Remove dead code 

    As found by SonarCloud.

Signed-off-by: Reto Schneider <code@reto-schneider.ch>
    @rettichschnidi
    rettichschnidi committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    b7bb296 View commit details
    Browse the repository at this point in the history