Improve ci 6 sonar #587
Closed
Improve ci 6 sonar #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will give us details coverage and static and static code analysis attached to every PR. To enable the integration, take the following steps: - Log in to https://sonarcloud.io/ using your GitHub account - Visit https://sonarcloud.io/projects/create, add Wakaama (fairly self-explanatory) - Create a PR in your repository to verify the integration Signed-off-by: Reto Schneider <code@reto-schneider.ch>
Found by SonarCloud. Signed-off-by: Reto Schneider <code@reto-schneider.ch>
SonarCloud has complained before. Signed-off-by: Reto Schneider <code@reto-schneider.ch>
|
I do not think this is helpful. To help reviewing my PR #573, you need to sign up with your own account to sonarcloud and create a PR in your own fork of this repository afterwards (using this branch). |
As found by SonarCloud. Signed-off-by: Reto Schneider <code@reto-schneider.ch> Signed-off-by: Leif Sandstrom <leif.sandstrom@husqvarnagroup.com>
qleisan
force-pushed
the
improve-ci-6-sonar
branch
from
c778bba
to
bfa976e
Compare
|
This should have been a PR to my fork repo... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test retos branch (PR573)
Not sure I'm doing this right...