Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codeql: Fix potential multiplication overflow #641

Merged
merged 1 commit into from
Jan 16, 2022
Merged

codeql: Fix potential multiplication overflow #641

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions coap/block.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,8 +257,7 @@ uint8_t prv_coap_block_handler(lwm2m_block_data_t ** pBlockDataHead,
uint8_t * oldBuffer = blockData->blockBuffer;
size_t oldSize = blockData->blockBufferSize;

if (blockData->blockBufferSize != blockSize * blockNum)
{
if (blockData->blockBufferSize != (size_t)blockSize * blockNum) {
// we don't receive block in right order
// TODO should we clean block1 data for this server ?
return COAP_408_REQ_ENTITY_INCOMPLETE;
Expand Down