Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce prototypes on functions #685

Conversation

rettichschnidi
Copy link
Contributor

@rettichschnidi rettichschnidi commented Mar 1, 2023

This is the first warning we actually enforce. Hopefully, many more will follow.

There are two commits: One for the functional changes, another one required by the code formatting rules. Probably best to review commit-by-commit.

@rettichschnidi rettichschnidi marked this pull request as draft March 1, 2023 12:27
@rettichschnidi rettichschnidi force-pushed the gardena/rs/enforce-strict-prototypes branch 2 times, most recently from ccfbcfb to 348244e Compare March 1, 2023 14:21
@rettichschnidi rettichschnidi force-pushed the gardena/rs/enforce-strict-prototypes branch from 348244e to 3333ac7 Compare March 11, 2023 16:59
This is the first warning we actually enforce. Hopefully, many more will
follow.
@rettichschnidi rettichschnidi force-pushed the gardena/rs/enforce-strict-prototypes branch from 3333ac7 to d4ebb93 Compare March 21, 2023 17:25
Make clang-format happy about the changes introduced in the last commit.
@rettichschnidi rettichschnidi force-pushed the gardena/rs/enforce-strict-prototypes branch from d4ebb93 to ea74b33 Compare March 21, 2023 17:37
@rettichschnidi rettichschnidi marked this pull request as ready for review March 22, 2023 08:02
Copy link
Contributor

@mlasch mlasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice contribution, improves code quality.

@rettichschnidi rettichschnidi merged commit 0ef0a08 into eclipse-wakaama:master Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants