Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

license: Rename license for Github to detect it #725

Merged

Conversation

mlasch
Copy link
Contributor

@mlasch mlasch commented Aug 9, 2023

Rename license for Github to detect it, similar to Leshan. #491

@mlasch mlasch force-pushed the gardena/ml/rename-license-files branch from f473296 to cf545fc Compare August 9, 2023 09:50
@mlasch mlasch requested a review from sbernard31 August 9, 2023 10:51
@sbernard31
Copy link
Contributor

I'm not sure it works to use EDL-1 suffix 🤔, did you check on your personal forked repository ?

It works if you can see : BSD-3-Clause, EPL-2.0 licenses found on the right of the github home page under tags.
Like in Leshan : https://github.com/eclipse-leshan/leshan

Note that EDL-1 license is exactly a BSD-3-Clause. (Leshan is also licensed under epl 2 and edl 1)
Why edl-1 is not supported ? I asked about it long time ago : https://lists.spdx.org/g/Spdx-legal/topic/22080928#2105
So it's expected that GitHub see edl1 as BSD-3 license.

@mlasch
Copy link
Contributor Author

mlasch commented Aug 17, 2023

I'm not sure it works to use EDL-1 suffix 🤔, did you check on your personal forked repository ?

The licenses will show up in Github as "Unknown, EPL-2.0 licenses found ". At least the EDL-1 is recognized as a license file, even though unknown.

Note that EDL-1 license is exactly a BSD-3-Clause.

Not sure I understand you correctly. Can we just replace EDL-1 with BSD-3 in Wakaama (same as with Leshan), or should we keep EDL-1 and accept that Github does not show it correctly? Both would be fine for me.

@sbernard31
Copy link
Contributor

Not sure I understand you correctly. Can we just replace EDL-1 with BSD-3 in Wakaama

I think you can replace EDL-1 with BSD-3.
@waynebeaton could you confirm that it's OK to replace EDL-1 suffix by BSD-3 suffix and so github is able to show BSD-3-Clause instance of Unknown ?

@boaks
Copy link

boaks commented Aug 17, 2023

I think you can replace EDL-1 with BSD-3.

At least that was the advice for Californium.

Rename EPL-2 license file and replace EDL-1 with BSD-3-Clause.
@mlasch mlasch force-pushed the gardena/ml/rename-license-files branch from cf545fc to 9eb0b86 Compare August 17, 2023 08:41
@mlasch mlasch merged commit 4bad452 into eclipse-wakaama:master Aug 17, 2023
31 checks passed
@waynebeaton
Copy link

Yes. In fact, the documentation generator recommends exactly this.

Use BSD-3-Clause if you can. While there's all kinds of standards, I find that there is a strong preference to using the SPDX code for the name of the file with an extension that describes the format, e.g., BSD-3-Clause.md or similar. This is not a requirement... just an observation.

FWIW, the BSD licenses are referred to as "template" licenses. When you use them, you change certain parts of the text, but they're basically still just the BSD license. So the EDL is just our appliaction of the BSD. From a license management perspective, it's way easier for everybody if we treat all of the various applications of the BSD uniformly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants