Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Update sonar-scanner Github action #743

Conversation

LukasWoodtli
Copy link
Contributor

The old version of the sonar-scanner depends on
nodejs 14 which is deprecated.

@@ -55,6 +59,7 @@ jobs:
-Dsonar.login=${{ secrets.SONAR_TOKEN }} \
-Dsonar.organization=${{ github.repository_owner }} \
-Dsonar.projectKey="$(echo ${{ github.repository }} | tr / _)" \
-Dsonar.organization=eclipse \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure this is not needed/harmful for forks:

WARN: Property 'sonar.organization' with value 'eclipse' is overridden with value 'eclipse'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes you are right. Missed that it was there already.

@LukasWoodtli
Copy link
Contributor Author

This is not working. I don't know why. Seems to be a problem with uploading the report. It might be an authorization problem. But I have not the right permissions to check that.
Abandoning the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants