Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix payload fragmentation in client SEND operation #770 #771

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sergioGras
Copy link

In this PR, I replaced the coap_set_payload function with transaction_set_payload. As a result, the client can now send large data in separate CoAP packets instead of a single large packet that was previously rejected by the server

…ixes eclipse-wakaama#770

Signed-off-by: Sergio Gras <sergio.gras@gi-de.com>
@LukasWoodtli
Copy link
Contributor

@sergioGras Thank you for your contribution!

You need to sign the Eclipse Contributor Agreement to provide a PR.

Please also provide a useful commit message.

Updated the payload method in the client SEND operation to avoid inserting large data into a single coap packet. Fixes eclipse-wakaama#770

Signed-off-by: Sergio Gras <sergio.gras@gi-de.com>
Copy link

sonarcloud bot commented May 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mlasch
Copy link
Contributor

mlasch commented Jun 17, 2024

You pushed a merge commit with your contribution. Can you please squash your commits into a single commit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants