Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wild web developer has useful code that could be used in other places #112

Closed
jonahgraham opened this issue Jan 8, 2019 · 9 comments
Closed

Comments

@jonahgraham
Copy link
Contributor

I would like to move a little bit of code higher up the stack from wildwebdeveloper to lsp4e.debug. Specifically InitializeLaunchConfigurations to make it easier for CDT's debug adapter and wildwebdeveloper's adapter to be more consistent on where to get node from.

I see this as a pre-cursor to having Node shipped in some way with CDT/wildwebdev.

The corresponding bug in lsp4e is Bug 543280

@mickaelistria
Copy link
Contributor

I think this somehow relates to #23 and detection of node.js should be in a separate bundle and not in main LSP4E bundle.
What do you think about Wild Web Developer hosting those node utils and CDT reusing them?

jonahgraham added a commit to jonahgraham/wildwebdeveloper that referenced this issue Jan 8, 2019
jonahgraham added a commit to jonahgraham/wildwebdeveloper that referenced this issue Jan 8, 2019
…ns to lsp4e.debug

Signed-off-by: Jonah Graham <jonah@kichwacoders.com>
@jonahgraham
Copy link
Contributor Author

What do you think about Wild Web Developer hosting those node utils and CDT reusing them?

OK, but only as a separate bundle.

@mickaelistria
Copy link
Contributor

OK, but only as a separate bundle.

Of course!

@guw
Copy link

guw commented Feb 25, 2019

@jonahgraham @mickaelistria What is the decision/action items on this one? I have a similar requirement, i.e. I'm about to build an Eclipse plug-in that ships a language server which requires Node at runtime. For best out of the box experience I'm investigating embedding Node in Eclipse.

I like to re-use anything that's been created here.

@mickaelistria
Copy link
Contributor

The decision is that Wild Web Developer could provide node.js detection or even embedder as a dedicated bundle that anyone would be free to reuse. It's now «only» a matter of someone actually doing the worl in wild web developer. To be clear, this is currently low priority to me, so don't count on me to do it in short future. But I'll try to review and merge contributions with high priority.

@jonahgraham
Copy link
Contributor Author

Hi @guw, +1 to what Mickael said. I would love to find the time to work on this, but it is low priority for me too. At the moment my energy is on a special project :-) https://twitter.com/JonahGrahamKC/status/1098531058100944898

@mickaelistria
Copy link
Contributor

Related #23

@mickaelistria
Copy link
Contributor

The node.js detector/embedder is now in place, in its own feature, and documented for external usage: https://github.com/eclipse/wildwebdeveloper/blob/master/org.eclipse.wildwebdeveloper.embedder.node/README.md . The current state IMO covers the initial request, so I'm closing it.
Testing, feedback and improvements are highly welcome (in new issues and new PRs).

@jonahgraham
Copy link
Contributor Author

Thank you @mickaelistria - I will encourage CDT devs to consume that code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants