New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wild web developer has useful code that could be used in other places #112
Comments
I think this somehow relates to #23 and detection of node.js should be in a separate bundle and not in main LSP4E bundle. |
…ns to lsp4e.debug
…ns to lsp4e.debug Signed-off-by: Jonah Graham <jonah@kichwacoders.com>
OK, but only as a separate bundle. |
Of course! |
@jonahgraham @mickaelistria What is the decision/action items on this one? I have a similar requirement, i.e. I'm about to build an Eclipse plug-in that ships a language server which requires Node at runtime. For best out of the box experience I'm investigating embedding Node in Eclipse. I like to re-use anything that's been created here. |
The decision is that Wild Web Developer could provide node.js detection or even embedder as a dedicated bundle that anyone would be free to reuse. It's now «only» a matter of someone actually doing the worl in wild web developer. To be clear, this is currently low priority to me, so don't count on me to do it in short future. But I'll try to review and merge contributions with high priority. |
Hi @guw, +1 to what Mickael said. I would love to find the time to work on this, but it is low priority for me too. At the moment my energy is on a special project :-) https://twitter.com/JonahGrahamKC/status/1098531058100944898 |
Related #23 |
The node.js detector/embedder is now in place, in its own feature, and documented for external usage: https://github.com/eclipse/wildwebdeveloper/blob/master/org.eclipse.wildwebdeveloper.embedder.node/README.md . The current state IMO covers the initial request, so I'm closing it. |
Thank you @mickaelistria - I will encourage CDT devs to consume that code. |
I would like to move a little bit of code higher up the stack from wildwebdeveloper to lsp4e.debug. Specifically InitializeLaunchConfigurations to make it easier for CDT's debug adapter and wildwebdeveloper's adapter to be more consistent on where to get node from.
I see this as a pre-cursor to having Node shipped in some way with CDT/wildwebdev.
The corresponding bug in lsp4e is Bug 543280
The text was updated successfully, but these errors were encountered: