New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maven build use node from PATH on mac os #1247
Comments
@zulus Thanks for pointing to the issue. I have no Mac to test, but I'll try setting up a GitHub action to run the tests. |
Well, I tried to create a Github Workflow to build and test WWD using MacOS:
... and having it configured to be pre-installed with Node.js v.20.x:
...I see the following
... which clearly shows that the embedded installation of Node.js (v18.16.0) is used to run an @zulus Are you sure your Unfortunately, I have no Mac to try debugging it locally. |
No, it means it use Eclipse built-in NPM. NPM script have on header On Windows you will see |
I'm afraid same problem might be on linux, I'll later confirm. Tests rather than use built-in one, use node from github actions. |
@zulus Yes, I think you're right - this is a real issue. Thanks for reporting it! |
Same on linux. Problem is with npm calls in general on *nix systems. Eclipse rely on PATH for all NPM cals, and completely ignore built-in node. Checked on fresh fedora 36 ARM64 (virtual machine), run as npm inside project. Result in console:
BTW would be nice if WWD could add to ENV[PATH] built-in node bin so TM Terminal could have an access ;) I can create separate task |
@zulus Yes. I can confirm. The only way I see to fix it is to modify those scripts replacing the We can't change the PATH environment variable pointing to the embedded binaries first to help the |
So npm runs should works in same way as we launch all language servers:
For now, on windows special CMD is created on the fly (magic |
On windows we can probably update the
Or even just change
with something like
(not sure what is the meaning of Not sure if this would work, though. |
For now this code always return true on MAC: https://github.com/eclipse/wildwebdeveloper/blob/e52e0990f609f3dcbac5648a4bd012ecf9d753a5
Due this process builder always receiving NPM absolute path only, so use node from PATH (if exists) or fail (
/bin/env node
)I think line from above should be just dropped, npm should always be prefixed by built-in node (if exists)
The text was updated successfully, but these errors were encountered: