Integrate Chrome debugger

[AObuchow]

I'm going to start working on integrating the chrome debugger as the vscode extension for it has a debuger adapter which is very similar to the node debugger's adapter.

[mickaelistria]

@AObuchow, I'm answering here the questions/comments you made on internal Slack

So far I haven't had too much success with the chrome debugger unfortunately
Maybe I'm just missing something but looking at https://github.com/microsoft/vscode-chrome-debug/blob/master/src/chromeDebugAdapter.ts
I realized there isn't any outer-most function call (function which gets called when the file is loaded)
there's only function declarations
so running node chromeDebugAdapter.js won't work
I was however, able to get the extension to work within vscode

One possibility is that when you get it working with vscode, you run some ps aux | grep node command to see what's the command invoked by VSCode. It may indeed be a different entry point to use.

[mickaelistria]

It seems like we should instead use https://github.com/microsoft/vscode-chrome-debug/blob/master/src/chromeDebugAdapter.ts (so include the vscode-chrome-debug module)

[AObuchow]

One possibility is that when you get it working with vscode, you run some ps aux | grep node command to see what's the command invoked by VSCode. It may indeed be a different entry point to use.

I didn't have much luck grepping for node but using the extension with VSCode and running ps aux | grep chrome gave me:
/usr/share/code/code -e delete process.env.ELECTRON_RUN_AS_NODE;require(process.argv[1]) /home/aobuchow/.vscode/extensions/msjsdiag.debugger-for-chrome-4.11.7/out/src/chromeDebug.js

It seems that the entry point might be chromeDebug.js rather than the adapter class. When running it with node, the process stays running/doesn't exit immediately. I'm going to experiement further with it.

[AObuchow]

Update: I just got Chrome to launch from Eclipse using chromeDebug.js :)
Hopefully things will go a bit more smoothly now.

[mickaelistria]

Great @AObuchow .
To embed it, you can mimic what was done in b1f39b6#diff-f5f4550a2038c2e52d1c95b8af5eb02e (pom.xml)

[mickaelistria]

Main patch in this story is merged. However I see that the Chrome Debug shortcut on right click starts a node.js debugger.
I think this is addressed in #251

[AObuchow]

Main patch in this story is merged. However I see that the Chrome Debug shortcut on right click starts a node.js debugger.
I think this is addressed in #251

Yes you're right. I just did a local rebase of my refactoring branch and the issue seems to be fixed there. Going to submit a PR now.

[mickaelistria]

Refactoring was merged and includes all the fix. The Chrome Debugger seems usable enough now. Thanks @AObuchow !

[AObuchow]

My pleasure :)!