Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nobug] Use maven provided dependencies instead of the Orbit provided… #1131

Merged
merged 1 commit into from Mar 21, 2023
Merged

[nobug] Use maven provided dependencies instead of the Orbit provided… #1131

merged 1 commit into from Mar 21, 2023

Conversation

vrubezhny
Copy link
Contributor

@vrubezhny vrubezhny commented Mar 16, 2023 •
edited

… ones

@vrubezhny vrubezhny force-pushed the fixDependenciesUseMaven branch 4 times, most recently from 6948d3d to f01a614 Compare March 17, 2023 21:41
@mickaelistria
Copy link
Contributor

[TestJSON.testFormatEnabled](https://ci.eclipse.org/wildwebdeveloper/job/Wildwebdeveloper/job/PR-1131/5/testReport/junit/org.eclipse.wildwebdeveloper.tests/TestJSON/testFormatEnabled/) seems to be persistently failing on CI with this change. Is it a regression that can be reproduced locally?

@vrubezhny
Copy link
Contributor Author

@mickaelistria I believe it's a failure similar to what we had in #1134 - commands are not fully initialized at the moment they statuses, like enablement, are acquired.

When I run the test locally from under Eclipse it succeeds, when I run it from the command line together with all other WWD tests it succeeds as well, but when I run this and only this test from the command line it fails - probably some initialization job isn't finished at the time of testing in this case.

@vrubezhny
Copy link
Contributor Author

#1142 Should fix the TestJSON.testFormatEnabled issue

@mickaelistria mickaelistria merged commit 363f70a into eclipse-wildwebdeveloper:master Mar 21, 2023
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vrubezhny @mickaelistria