VSCode 1.54 #618
Merged
VSCode 1.54 #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
VSCode ships newer major version of the vscode-json-languageservice so it's not compatible with yaml-language-server any more and requires to duplicate multiple version of libraries, leading to path too long. I suggest we simply wait for yaml-language-server to use newer major of vscode-json-language server before updating VSCode. |
|
Sounds good. Please open issue for yaml-language-server so we know what exactly we wait for. |
mickaelistria
force-pushed
the
vscode-1.53
branch
from
e501210
to
d6906d9
Compare
mickaelistria
force-pushed
the
vscode-1.53
branch
2 times, most recently
from
37a137a
to
85db59b
Compare
+ yaml-language-server 0.16.0 + chrome-debug-adapter 4.12.12 Signed-off-by: Mickael Istria <mistria@redhat.com>
mickaelistria
force-pushed
the
vscode-1.53
branch
from
85db59b
to
ec93679
Compare
|
Submitted CQs http://dev.eclipse.org/ipzilla/show_bug.cgi?id=23161 and http://dev.eclipse.org/ipzilla/show_bug.cgi?id=23160 , other deps are approved by dash-license tool. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mickael Istria mistria@redhat.com