Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add build configuration without shared memory #406

Closed
milyin opened this issue May 30, 2024 · 2 comments
Closed

add build configuration without shared memory #406

milyin opened this issue May 30, 2024 · 2 comments
Labels
release Part of the next release

Comments

@milyin
Copy link
Contributor

milyin commented May 30, 2024

Describe the release item

Some customers needs zenoh-c wihout shared memory enabled. There should be cmake option for it and this configuration should be tested in CI

@milyin milyin added the release Part of the next release label May 30, 2024
@yellowhatter
Copy link
Contributor

A few comments on this....

I did an investigation that highlighted the following problems:

  1. Some pieces of our codegeneration process do not intend to support features. Practically it means that zenoh-c cannot conditionally exclude some API bindings. To be fixed
  2. Turning off shared-memory feature in underlying Zenoh changes some type's sizes and break some hacky assumptions made for ZBytes in zenoh-c. To be refactored.

Currently we had a discussion with API crew on important details and I'm in progress with this issue

@milyin
Copy link
Contributor Author

milyin commented Jul 1, 2024

done, zenoh-c builds correctly with different features in Cargo.toml.in

@milyin milyin closed this as completed Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Part of the next release
Projects
Status: Done
Development

No branches or pull requests

2 participants