z_bytes: expose wrap and rename new to from_str

include/zenoh_commons.h

@@ -952,6 +952,12 @@ ZENOHC_API struct z_attachment_t z_attachment_null(void);
  * Returns ``true`` if `b` is initialized.
  */
 ZENOHC_API bool z_bytes_check(const struct z_bytes_t *b);
+/**
+ * Returns a view of `str` using `strlen` (this should therefore not be used with untrusted inputs).
+ *
+ * `str == NULL` will cause this to return `z_bytes_null()`
+ */
+ZENOHC_API struct z_bytes_t z_bytes_from_str(const char *str);
 /**
  * Aliases `this` into a generic `z_attachment_t`, allowing it to be passed to corresponding APIs.
  */
@@ -1031,16 +1037,14 @@ ZENOHC_API struct z_owned_bytes_map_t z_bytes_map_new(void);
  * Constructs the gravestone value for `z_owned_bytes_map_t`
  */
 ZENOHC_API struct z_owned_bytes_map_t z_bytes_map_null(void);
-/**
- * Returns a view of `str` using `strlen`.
- *
- * `str == NULL` will cause this to return `z_bytes_null()`
- */
-ZENOHC_API struct z_bytes_t z_bytes_new(const char *str);
 /**
  * Returns the gravestone value for `z_bytes_t`
  */
 ZENOHC_API struct z_bytes_t z_bytes_null(void);
+/**
+ * Constructs a `len` bytes long view starting at `start`.
+ */
+ZENOHC_API struct z_bytes_t z_bytes_wrap(const uint8_t *start, size_t len);
 /**
  * Closes a zenoh session. This drops and invalidates `session` for double-drop safety.
  *

src/collections.rs

@@ -61,12 +61,12 @@ pub extern "C" fn z_bytes_null() -> z_bytes_t {
     }
 }
 
-/// Returns a view of `str` using `strlen`.
+/// Returns a view of `str` using `strlen` (this should therefore not be used with untrusted inputs).
 ///
 /// `str == NULL` will cause this to return `z_bytes_null()`
 #[no_mangle]
 #[allow(clippy::missing_safety_doc)]
-pub unsafe extern "C" fn z_bytes_new(str: *const c_char) -> z_bytes_t {
+pub unsafe extern "C" fn z_bytes_from_str(str: *const c_char) -> z_bytes_t {
     if str.is_null() {
         z_bytes_null()
     } else {
@@ -78,6 +78,17 @@ pub unsafe extern "C" fn z_bytes_new(str: *const c_char) -> z_bytes_t {
     }
 }
 
+/// Constructs a `len` bytes long view starting at `start`.
+#[no_mangle]
+#[allow(clippy::missing_safety_doc)]
+pub unsafe extern "C" fn z_bytes_wrap(start: *const u8, len: usize) -> z_bytes_t {
+    if start.is_null() {
+        z_bytes_null()
+    } else {
+        z_bytes_t { len, start }
+    }
+}
+
 /// Frees `b` and invalidates it for double-drop safety.
 #[allow(clippy::missing_safety_doc)]
 pub(crate) unsafe fn z_bytes_drop(b: &mut z_bytes_t) {