Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding complete option to publication_cache #243

Merged
merged 10 commits into from
Feb 15, 2024
Merged

adding complete option to publication_cache #243

merged 10 commits into from
Feb 15, 2024

Conversation

milyin
Copy link
Contributor

@milyin milyin commented Feb 8, 2024

@eclipse-zenoh-bot
Copy link
Contributor

@milyin If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

@milyin milyin marked this pull request as ready for review February 12, 2024 13:48
@milyin milyin requested a review from Mallets February 12, 2024 13:50
Cargo.toml Outdated Show resolved Hide resolved
include/zenoh_commons.h Outdated Show resolved Hide resolved
Copy link
Member

@Mallets Mallets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the documentation typo. All the rest LGTM.

Cargo.toml.in Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
src/info.rs Outdated Show resolved Hide resolved
@milyin milyin merged commit de57b3f into main Feb 15, 2024
9 checks passed
@milyin milyin deleted the pubcache_complete branch February 15, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Expose completeness option in PublicationCach in Rust, C, C++
4 participants