Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(user_attachment): user attachment implementation #41

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

DariusIMP
Copy link
Contributor

@DariusIMP DariusIMP commented Feb 23, 2024

User attachment for Java Bindings.

The API is expanded with the following calls:

  • publisher.put(...).with_attachment(attachment)
  • publisher.write(...).with_attachment(attachment)
  • publisher.delete(...).with_attachment(attachment)
  • session.put(...).with_attachment(attachment)
  • query.reply(...).with_attachment(attachment)
  • session.get(...).with_attachment(attachment)

The Sample class now has an optional Attachment field as well.

Closes #29

@eclipse-zenoh-bot
Copy link
Contributor

@DariusIMP If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

Copy link
Member

@JEnoch JEnoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar changes than #38 that have already been reviewed and approved.
I have no reason to not re-approve 😁

@DariusIMP DariusIMP mentioned this pull request Feb 23, 2024
@JEnoch JEnoch merged commit 97b2a5c into eclipse-zenoh:main Feb 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User attachment implementation
3 participants