Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changes to make zenohpico compatible with zenoh-cpp #190

Merged
merged 62 commits into from
Apr 6, 2023
Merged

changes to make zenohpico compatible with zenoh-cpp #190

merged 62 commits into from
Apr 6, 2023

Conversation

milyin
Copy link
Contributor

@milyin milyin commented Apr 3, 2023

  • missing generics and templates added, macros file made similar to zenohc one
  • few missing API functions and structures added (timestamp, closure call functions)
  • consts added, some fields renamed and changed places to make initalizer works universally

milyin and others added 30 commits March 3, 2023 14:54
@milyin
target_include_directories to export include path
1696813
@milyin
null methods added
901a22f
@milyin
z_XXX_null() added
080c2f6
@milyin
Merge branch 'eclipse-zenoh:master' into zenohcpp_zenohpico
cede1cc
@milyin
undoed separate z_str_array_t
a893ed0
@milyin
StrArrayView val, len no underscores
90f600d
@milyin
bytes field order same as in zenoh-c
256eb9d
@milyin
z_keyexpr_as_bytes added
fa8aa61
@milyin
timestamp updated
b58cea6
@milyin
bytes_check, closure calls
b0665b7
@milyin
z_keyexpr_new
b014490
@milyin
const added
5f7a50a
@milyin
build tests, examples, installation only if root
df3324c
@milyin
keyexpr_unchecked, z_xxx_null
b7bb240
@milyin
same fields order as in zenohc
42b6373
@milyin
trailing zero not included to z_keyexpr_as_bytes
2c72550
@milyin
create null owned keyexpr if null parameter passed
baa27fe
@milyin
canonizer fix for one-character chunks
e4854db
@milyin
undef ndebug right before tests
d1c4a31
@milyin
Merge branch 'keyexpr_canon_fix' into zenohcpp_zenohpico
a566d4f
@milyin
return -1 only if keyexpr invalid
ae7b578
@milyin
Merge branch 'zero_is_true_api_change' into zenohcpp_zenohpico
b66331a
@milyin
test corrected
d2cf7f8
@milyin
Merge branch 'zero_is_true_api_change' into zenohcpp_zenohpico
aaa0ec7
@milyin
session test
a0320ed
@milyin
crash on close null session
33b130e
@milyin
fix crash on double session close
bd28b98
@cguimaraes
Update keyexpr functions
fa5d63f
@milyin
Merge branch 'zero_is_true_api_change' into zenohcpp_zenohpico
586895f
@milyin
Merge branch 'master' into zenohcpp_zenohpico
1ea40a1
@milyin
part of remarks fixed
8e8ddae
@milyin
correct return on out of memory
c572283
@milyin
restored reply_t as field, cleanup in new
04de2ce
@milyin
restored incorrectly moved lines
3d0bad0
@milyin
rename to alloc_and_move
d524740
@milyin
Merge branch 'callback_double_drop_crash_fix' into zenohcpp_zenohpico
b1d977b
@milyin
make thread stop work immediately after run
999ec2b
@milyin
add .clang-format
c2b42a9
@milyin
Merge branch 'clang-format' into zenohcpp_zenohpico
fb7836b
@milyin
Merge branch 'immediate_stop_fail_fix' into zenohcpp_zenohpico
0509cfc
@milyin
Merge branch 'eclipse-zenoh:master' into zenohcpp_zenohpico
33b1773
@milyin
Merge branch 'master' into zenohcpp_zenohpico
c47d948
@milyin
examples CMakeLists in separate directory
cb24219
@milyin
make cmakelists includable
c0e7aff
@milyin
windows build fix
c1a5072
@milyin
Merge branch 'cmakelists_includable' into zenohcpp_zenohpico
b549bf9
@milyin
obsolete JNI_PLATFORM_NAME removed
c43b2af
@milyin
helpers.cmake formatted
9ff3725
@milyin
gitignore updated
7f2ee6f
@milyin
Merge branch 'master' into cmakelists_includable
93e2030
@milyin
cmake-format added
25ed137
@milyin
Merge branch 'cmakelists_includable' into zenohcpp_zenohpico
79b3fa6
@milyin
Merge branch 'master' into zenohcpp_zenohpico
4f9a125
@cguimaraes cguimaraes mentioned this pull request Apr 4, 2023
Closed
cguimaraes
cguimaraes reviewed Apr 4, 2023
View reviewed changes
Copy link
Member

@cguimaraes cguimaraes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but some clarification asked

include/zenoh-pico/api/primitives.h Outdated Show resolved Hide resolved
include/zenoh-pico/api/primitives.h Outdated Show resolved Hide resolved
include/zenoh-pico/collections/bytes.h Outdated Show resolved Hide resolved
include/zenoh-pico/collections/string.h Show resolved Hide resolved
include/zenoh-pico/protocol/core.h Show resolved Hide resolved
include/zenoh-pico/collections/string.h Show resolved Hide resolved
include/zenoh-pico/protocol/core.h Show resolved Hide resolved
@milyin milyin mentioned this pull request Apr 5, 2023
Merged
@cguimaraes cguimaraes merged commit c79de85 into eclipse-zenoh:master Apr 6, 2023
27 checks passed
@milyin milyin deleted the zenohcpp_zenohpico branch April 6, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cguimaraes cguimaraes cguimaraes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@milyin @cguimaraes