Add support for zephyr #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Esteve Fernandez <esteve@apache.org>
Signed-off-by: Esteve Fernandez <esteve@apache.org>
Signed-off-by: Esteve Fernandez <esteve@apache.org>
Signed-off-by: Esteve Fernandez <esteve@apache.org>
Mallets
reviewed
Apr 1, 2021
| return r; | ||
| } | ||
|
|
||
| // NOTE(esteve): SO_KEEPALIVE and SO_LINGER not supported in Zephyr |
There was a problem hiding this comment.
I would simply remove the commented code and leave the note saying that those flags are not supported in Zephyr.
Mallets
reviewed
Apr 1, 2021
src/net/zephyr/network.c
Outdated
|
|
||
| return 0; | ||
| } | ||
|
|
There was a problem hiding this comment.
I would simply remove the commented code and leave the note saying that iovec is not supported in Zephyr.
|
@esteve I went through your PR and it seems fine to me. Thanks for adding the support for Zephyr into zenoh-pico! For what concerns the socket flags, they are not mandatory in zenoh-pico. It's only a matter of tuning that we found beneficial on UNIX systems. If those flags are not supported in Zephyr, let's simply ignore them. |
Signed-off-by: Esteve Fernandez <esteve@apache.org>
Signed-off-by: Esteve Fernandez <esteve@apache.org>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Mallets this PR has many changes, let me know if you'd like me to break it out:
#ifs to just check if the macros had been defined.strdup, since Zephyr does not provide it_times()when callingclock(), I replaced thesrand()initialization to just usetime()