Measure wall time in ping tests #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mallets
approved these changes
Oct 25, 2023
jean-roland
force-pushed
the
fix_ping_tests
branch
from
651294c
to
2a56883
Compare
cguimaraes
reviewed
Oct 26, 2023
For Windows, in Rust they base the clock implementation on QueryPerformanceCounter. We might think about updating the Windows port to that but I'd leave it as a new PR. |
Mallets
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ping tests were measuring CPU time where what was needed was wall time. Additional bonus, using the zenoh defined primitives ensures better system compatibility.