Add support for qos settings in sample #348
Conversation
|
@DenisBiryukov91 If this pull request contains a bugfix or a new feature, then please consider using |
- add missing dots in docs
| z_congestion_control_t congestion_control; | ||
| bool express; | ||
| } _z_qos_t; | ||
|
|
There was a problem hiding this comment.
The comment and the structure do not agree on type visibility (_z_priority_t vs z_priority_t), also we use _Bool for booleans generally.
| @@ -227,6 +241,7 @@ typedef struct { | |||
| _z_timestamp_t timestamp; | |||
| _z_encoding_t encoding; | |||
| z_sample_kind_t kind; | |||
| _z_qos_t qos; | |||
There was a problem hiding this comment.
Pretty sure by putting the private type here, the public alias z_qos_t is never used. So I'm tempted to use z_qos_t instead, if that doesn't cause include issues.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -29,7 +29,8 @@ | |||
| break; | |||
| } | |||
| } | |||
| printf("[rx]: Received packet on %s, len: %d, validity: %d\n", z_loan(keystr), (int)sample->payload.len, is_valid); | |||
| printf("[rx]: Received packet on %s, len: %d, validity: %d, qos {priority: %d, cong_ctrl: %d}\n", z_loan(keystr), | |||
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 17.7 rule Note
- replace _z_n_qos_unmake with _z_n_qos_unmake_public in subscription.c
| */ | ||
| static inline z_priority_t z_qos_get_priority(z_qos_t qos) { | ||
| z_priority_t ret = _z_n_qos_get_priority(qos); | ||
| return ret == _Z_PRIORITY_CONTROL ? Z_PRIORITY_DEFAULT : ret; |
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 12.1 rule Note
Add support for qos settings in sample (see eclipse-zenoh/zenoh#730)