Add query and reply channels #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sashacmc
force-pushed
the
add_query_reply_channels
branch
from
7c4826d
to
c23333d
Compare
Mallets
reviewed
Apr 11, 2024
examples/unix/c11/z_get_channel.c
Outdated
| } | ||
|
|
||
| z_owned_reply_t reply = z_reply_null(); | ||
| z_call(channel.recv, &reply); |
There was a problem hiding this comment.
I think we should use for(z_call(..), z_check(..), z_call(..)). The current code only reads one reply but it does not wait for all the replies to arrive.
Mallets
approved these changes
Apr 11, 2024
|
@jean-roland this PR looks good to me. However the CI seems to fail. I believe the failure is not related to the changes proposed in this PR but I'm not 100% sure. Could you please double check? |
|
There are issues that are fixed by #399 but there also seems to be issues related to this PR when some features are disabled. |
|
Thanks @jean-roland, I will take a look |
sashacmc
force-pushed
the
add_query_reply_channels
branch
from
fc35ea5
to
41f728d
Compare
sashacmc
force-pushed
the
add_query_reply_channels
branch
from
41f728d
to
a6e1278
Compare
|
I fixed the compilation with disabled features and the memory leak (thanks @jean-roland for pointing out) |
Mallets
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add query and reply channels:
Add examples: