Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove zenoh::scouting::WhatAmI reexport #1062

Merged

Conversation

wyfo
Copy link

@wyfo wyfo commented May 29, 2024

WhatAmI is already present in zenoh::config.

This PR is based on #1007, so it will be draft until its base is merged.

@wyfo wyfo marked this pull request as draft May 29, 2024 15:03
@wyfo
Copy link
Author

wyfo commented May 29, 2024

@milyin

@wyfo wyfo force-pushed the remove_scouting_whatami branch from 8250f79 to 5e1c2b2 Compare May 31, 2024 05:25
@wyfo wyfo marked this pull request as ready for review May 31, 2024 05:26
`WhatAmI` is already present in `zenoh::config`.
@wyfo wyfo force-pushed the remove_scouting_whatami branch from 5e1c2b2 to f834d88 Compare May 31, 2024 05:33
@Mallets Mallets merged commit 382658a into eclipse-zenoh:dev/1.0.0 May 31, 2024
11 checks passed
@Mallets Mallets deleted the remove_scouting_whatami branch May 31, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

2 participants