Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no-default-features compilation #1127

Closed
wants to merge 2 commits into from
Closed

Conversation

Mallets
Copy link
Member

@Mallets Mallets commented Jun 12, 2024

Makes cargo clippy --all-targets --no-default-features happy.

@@ -45,7 +45,7 @@ transport_compression = []
transport_unixpipe = ["zenoh-link/transport_unixpipe"]
transport_vsock= ["zenoh-link/transport_vsock"]
stats = ["zenoh-protocol/stats"]
test = []
test = ["zenoh-protocol/test"]
unstable = []
default = ["test", "transport_multilink"]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is "test" a default feature?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It had to do with release on crates.io that does not like self import in dev-dependencies.

@fuzzypixelz I remember there was an issue related to that but I'm not able to find it anymore.

@wyfo
Copy link

wyfo commented Jun 13, 2024

By the way, I've also added no-default-features, but for zenoh only, in #1131. This check is still useful, as the code you fixed shows.

@Mallets
Copy link
Member Author

Mallets commented Jun 13, 2024

Superseded by #1131

@Mallets Mallets closed this Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants