Explicitly specify the default features in the examples. #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@YuanYuYuan If this pull request contains a bugfix or a new feature, then please consider using |
Mallets
reviewed
Mar 25, 2024
| @@ -49,7 +49,7 @@ futures = { workspace = true } | |||
| git-version = { workspace = true } | |||
| json5 = { workspace = true } | |||
| log = { workspace = true } | |||
| zenoh = { workspace = true } | |||
| zenoh = { workspace = true, default-features = true } | |||
| zenoh-ext = { workspace = true } | |||
There was a problem hiding this comment.
What about enabling default-features as well in zenoh-ext?
There was a problem hiding this comment.
A cargo tree -f "{p} {f}" running under zenoh/examples shows
└── zenoh-ext v0.11.0-dev (/home/circle/Workings/ZettaScale/src/zenoh/zenoh-ext) default
├── bincode v1.3.3
│ └── serde v1.0.188 alloc,default,derive,serde_derive,std (*)
├── env_logger v0.11.2 auto-color,color,default,humantime,regex (*)
├── flume v0.11.0 async,default,eventual-fairness,futures-core,futures-sink,nanorand,select (*)
├── futures v0.3.28 alloc,async-await,default,executor,futures-executor,std (*)
├── log v0.4.20 kv_unstable,std,value-bag (*)
├── serde v1.0.188 alloc,default,derive,serde_derive,std (*)
├── tokio v1.36.0 bytes,default,fs,io-std,io-util,libc,macros,mio,net,num_cpus,rt,rt-multi-thread,socket2,sync,time,tokio-macros (*)
├── zenoh v0.11.0-dev (/home/circle/Workings/ZettaScale/src/zenoh/zenoh) auth_pubkey,auth_usrpwd,default,transport_compression,transport_multilink,transport_quic,transport_tcp,transport_tls,transport_udp,transport_unixsock-stream,transport_ws,unstable (*)
├── zenoh-core v0.11.0-dev (/home/circle/Workings/ZettaScale/src/zenoh/commons/zenoh-core) default,std (*)
├── zenoh-macros v0.11.0-dev (proc-macro) (/home/circle/Workings/ZettaScale/src/zenoh/commons/zenoh-macros) (*)
├── zenoh-result v0.11.0-dev (/home/circle/Workings/ZettaScale/src/zenoh/commons/zenoh-result) default,std (*)
├── zenoh-runtime v0.11.0-dev (/home/circle/Workings/ZettaScale/src/zenoh/commons/zenoh-runtime) (*)
├── zenoh-sync v0.11.0-dev (/home/circle/Workings/ZettaScale/src/zenoh/commons/zenoh-sync) (*)
└── zenoh-util v0.11.0-dev (/home/circle/Workings/ZettaScale/src/zenoh/commons/zenoh-util) default,std (*)So I think we can omit it.
Mallets
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To resolve the issue in eclipse-zenoh/roadmap#128 (reply in thread). Users obtain an example built without default features if they run
cargo build --example EXAMPLEin the examples folder. Although adding--workspacecan solve this problem, it's still better to avoid this confusion completely.