fix(replication): do not reply an error when a key is not found #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed internally, a reply to a query should not return an error when a key does not exist — this is a perfectly valid situation. In addition, this prevented the replication from correctly functioning: as an error was always returned by the storage that was actually looking for the data, other replies were not processed and that storage would thus never receive anything. * plugins/zenoh-plugin-storage-manager/src/replica/storage.rs: deleted the code replying an error to a query looking for a key the storage does not have. Signed-off-by: Julien Loudet <julien.loudet@zettascale.tech>
Mallets
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed internally, a reply to a query should not return an error when a key does not exist — this is a perfectly valid situation.
In addition, this prevented the replication from correctly functioning: as an error was always returned by the storage that was actually looking for the data, other replies were not processed and that storage would thus never receive anything.