Remove keyexpr with_parameters #979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyfo
reviewed
Apr 25, 2024
Co-authored-by: Joseph Perez <joperez@hotmail.fr>
|
It's more about removing unnecessary API that needs to be supported in the various bindings. I don't see much difference in the actual API usage in terms of complexity (at least as it was used in the zenoh codebase) and it will remove the need of eexposing the method on all other languages. |
|
Fair point, I will remove it from the Python API so 🙃 |
|
LGTM |
wyfo
added a commit
to ZettaScaleLabs/zenoh-python
that referenced
this pull request
Apr 25, 2024
wyfo
added a commit
to ZettaScaleLabs/zenoh-python
that referenced
this pull request
Apr 25, 2024
wyfo
added a commit
to ZettaScaleLabs/zenoh-python
that referenced
this pull request
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #974