Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shm refine #986

Merged
merged 25 commits into from
May 3, 2024
Merged

Shm refine #986

merged 25 commits into from
May 3, 2024

Conversation

yellowhatter
Copy link
Contributor

No description provided.

@Mallets
Copy link
Member

Mallets commented Apr 30, 2024 •
edited
Loading

As part of the SHM refine, I believe we should rename zsliceshm and zsliceshmmut to something more compact.
For example:

  • zsliceshm -> zshm | shmbuf
  • zsliceshmmut -> zshmmut | shmbufmut

I tend to prefer shmbuf and shmbufmut because it does not present the double mm as in zshmmut.
In any case, any other proposal is well accepted.

@yellowhatter
Merge commit '8fe5ab5852fdaa18a88f450d4531d9fbbfbc7531'
0c399ec 
Conflicts:
	examples/examples/z_payload_shm.rs
	examples/examples/z_sub_shm.rs
	zenoh/tests/payload.rs
@yellowhatter
Massive renaming for ZSliceShm and ZSliceShmMut
bca2fd7
@yellowhatter
fix ci
ccb960d
@yellowhatter
[skip ci] z_payload_shm -> z_bytes_shm
bd5a0da
@yellowhatter
Polish SHM examples
c4dfd10
@yellowhatter
Merge commit 'c3f993da4baf385adb04d17f911790ca0becec41'
564567e 
Conflicts:
	examples/examples/z_get_shm.rs
	examples/examples/z_queryable_shm.rs
@yellowhatter yellowhatter mentioned this pull request May 2, 2024
Closed
@yellowhatter
fix lints
446fa2f
@yellowhatter
fix lint
74b444e
@yellowhatter
Merge commit 'b27a289931dfb317ee5e6696d23cd16251d9b61e'
0151db6 
Conflicts:
	commons/zenoh-shm/src/api/buffer/zshm.rs
	commons/zenoh-shm/src/api/provider/types.rs
	commons/zenoh-shm/src/api/slice/zsliceshm.rs
	zenoh/src/lib.rs
	zenoh/src/prelude.rs
@yellowhatter
fix after merge
77654a0
@yellowhatter
Update z_alloc_shm.rs
9fb1e19
@Mallets Mallets merged commit 511bc67 into eclipse-zenoh:protocol_changes May 3, 2024
11 checks passed
@Mallets Mallets deleted the shm_refine branch May 3, 2024 13:14
@yellowhatter yellowhatter restored the shm_refine branch May 3, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mallets Mallets Mallets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Zenoh 1.0.0 release
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yellowhatter @Mallets