-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/docker branch tagging #52
Merged
tlobig
merged 54 commits into
eclipse:dev_v0.3.2_bs
from
akoerner1:feature/docker-branch-tagging
Mar 21, 2023
Merged
Feature/docker branch tagging #52
tlobig
merged 54 commits into
eclipse:dev_v0.3.2_bs
from
akoerner1:feature/docker-branch-tagging
Mar 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 1, 2022
Closed
akoerner1
commented
Dec 1, 2022
- "ROS_HOME=${ADORE_SOURCE_DIRECTORY}/.log/.ros" | ||
- "ADORE_SOURCE_DIRECTORY=${ADORE_SOURCE_DIRECTORY}" | ||
- "HISTFILE=${ADORE_SOURCE_DIRECTORY}/.zsh_history" | ||
- "ROS_MASTER_URI=http://127.0.0.1:11311" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need to be modified to change the ross master to another host. I recommend somehting such as:
- ROS_MASTER_HOST=${ROS_MASTER_HOST:-127.0.0.1}
- "ROS_MASTER_URI=http://${ROS_MASTER_HOST}:11311"
- "ROS_HOSTNAME=${ROS_MASTER_HOST}"
Then the ros master host can be arbitrarily set as an environment variable or it defaults to 127.0.0.1 during docker compose run aka adore-cli.
…get and aptitude for normal user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains several major changes to the build system.
-Any downstream docker context that needs to consume a given image can then provide the tag as a build argument as follows: