Merge pull request #68 from kingargyle/findbugs

[460526] More Tweaks to findbugs filters
eclipse · Mar 1, 2015 · 55752ad · 55752ad
2 parents c3994a9 + 8756f31
commit 55752ad
Show file tree

Hide file tree

Showing 29 changed files with 261 additions and 87 deletions.
diff --git a/andmore-core/plugins/android.codeutils/findbugsExclusion.xml b/andmore-core/plugins/android.codeutils/findbugsExclusion.xml
@@ -3,8 +3,14 @@
 
     <Match>
         <Bug pattern="VA_FORMAT_STRING_USES_NEWLINE" />
-        <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>
-        <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>
-        <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>
+    </Match>
+    <Match>
+        <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>   
+    </Match>
+    <Match>
+        <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>    
+    </Match>
+    <Match>
+        <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>    
     </Match>
 </FindBugsFilter>
diff --git a/andmore-core/plugins/android.macosx/findbugsExclusion.xml b/andmore-core/plugins/android.macosx/findbugsExclusion.xml
@@ -3,8 +3,14 @@
 
     <Match>
         <Bug pattern="VA_FORMAT_STRING_USES_NEWLINE" />
-        <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>
-        <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>
-        <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>
+    </Match>
+    <Match>
+        <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>   
+    </Match>
+    <Match>
+        <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>    
+    </Match>
+    <Match>
+        <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>    
     </Match>
 </FindBugsFilter>
diff --git a/andmore-core/plugins/android/findbugsExclusion.xml b/andmore-core/plugins/android/findbugsExclusion.xml
@@ -3,8 +3,14 @@
 
     <Match>
         <Bug pattern="VA_FORMAT_STRING_USES_NEWLINE" />
-        <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>
-        <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>
-        <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>
+    </Match>
+    <Match>
+        <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>   
+    </Match>
+    <Match>
+        <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>    
+    </Match>
+    <Match>
+        <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>    
     </Match>
 </FindBugsFilter>
diff --git a/andmore-core/plugins/certmanager/findbugsExclusion.xml b/andmore-core/plugins/certmanager/findbugsExclusion.xml
@@ -3,8 +3,14 @@
 
     <Match>
         <Bug pattern="VA_FORMAT_STRING_USES_NEWLINE" />
-        <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>
-        <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>
-        <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>
+    </Match>
+    <Match>
+        <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>   
+    </Match>
+    <Match>
+        <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>    
+    </Match>
+    <Match>
+        <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>    
     </Match>
 </FindBugsFilter>
diff --git a/andmore-core/plugins/common/findbugsExclusion.xml b/andmore-core/plugins/common/findbugsExclusion.xml
@@ -3,8 +3,14 @@
 
     <Match>
         <Bug pattern="VA_FORMAT_STRING_USES_NEWLINE" />
-        <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>
-        <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>
-        <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>
+    </Match>
+    <Match>
+        <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>   
+    </Match>
+    <Match>
+        <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>    
+    </Match>
+    <Match>
+        <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>    
     </Match>
 </FindBugsFilter>
diff --git a/andmore-core/plugins/db.core/findbugsExclusion.xml b/andmore-core/plugins/db.core/findbugsExclusion.xml
@@ -3,8 +3,14 @@
 
     <Match>
         <Bug pattern="VA_FORMAT_STRING_USES_NEWLINE" />
-        <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>
-        <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>
-        <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>
+    </Match>
+    <Match>
+        <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>   
+    </Match>
+    <Match>
+        <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>    
+    </Match>
+    <Match>
+        <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>    
     </Match>
 </FindBugsFilter>
diff --git a/andmore-core/plugins/db.devices/findbugsExclusion.xml b/andmore-core/plugins/db.devices/findbugsExclusion.xml
@@ -3,8 +3,14 @@
 
     <Match>
         <Bug pattern="VA_FORMAT_STRING_USES_NEWLINE" />
-        <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>
-        <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>
-        <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>
+    </Match>
+    <Match>
+        <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>   
+    </Match>
+    <Match>
+        <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>    
+    </Match>
+    <Match>
+        <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>    
     </Match>
 </FindBugsFilter>
diff --git a/andmore-core/plugins/devices.services/findbugsExclusion.xml b/andmore-core/plugins/devices.services/findbugsExclusion.xml
@@ -3,8 +3,14 @@
 
     <Match>
         <Bug pattern="VA_FORMAT_STRING_USES_NEWLINE" />
-        <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>
-        <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>
-        <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>
+    </Match>
+    <Match>
+        <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>   
+    </Match>
+    <Match>
+        <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>    
+    </Match>
+    <Match>
+        <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>    
     </Match>
 </FindBugsFilter>
diff --git a/andmore-core/plugins/emulator/findbugsExclusion.xml b/andmore-core/plugins/emulator/findbugsExclusion.xml
@@ -3,8 +3,14 @@
 
     <Match>
         <Bug pattern="VA_FORMAT_STRING_USES_NEWLINE" />
-        <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>
-        <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>
-        <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>
+    </Match>
+    <Match>
+        <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>   
+    </Match>
+    <Match>
+        <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>    
+    </Match>
+    <Match>
+        <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>    
     </Match>
 </FindBugsFilter>
diff --git a/andmore-core/plugins/handset/findbugsExclusion.xml b/andmore-core/plugins/handset/findbugsExclusion.xml
@@ -3,8 +3,14 @@
 
     <Match>
         <Bug pattern="VA_FORMAT_STRING_USES_NEWLINE" />
-        <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>
-        <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>
-        <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>
+    </Match>
+    <Match>
+        <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>   
+    </Match>
+    <Match>
+        <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>    
+    </Match>
+    <Match>
+        <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>    
     </Match>
 </FindBugsFilter>
diff --git a/andmore-core/plugins/installer/findbugsExclusion.xml b/andmore-core/plugins/installer/findbugsExclusion.xml
@@ -3,8 +3,14 @@
 
     <Match>
         <Bug pattern="VA_FORMAT_STRING_USES_NEWLINE" />
-        <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>
-        <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>
-        <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>
+    </Match>
+    <Match>
+        <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>   
+    </Match>
+    <Match>
+        <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>    
+    </Match>
+    <Match>
+        <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>    
     </Match>
 </FindBugsFilter>
diff --git a/andmore-core/plugins/launch/findbugsExclusion.xml b/andmore-core/plugins/launch/findbugsExclusion.xml
@@ -3,8 +3,14 @@
 
     <Match>
         <Bug pattern="VA_FORMAT_STRING_USES_NEWLINE" />
-        <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>
-        <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>
-        <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>
+    </Match>
+    <Match>
+        <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>   
+    </Match>
+    <Match>
+        <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>    
+    </Match>
+    <Match>
+        <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>    
     </Match>
 </FindBugsFilter>
diff --git a/andmore-core/plugins/logger.collector/findbugsExclusion.xml b/andmore-core/plugins/logger.collector/findbugsExclusion.xml
@@ -3,8 +3,14 @@
 
     <Match>
         <Bug pattern="VA_FORMAT_STRING_USES_NEWLINE" />
-        <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>
-        <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>
-        <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>
+    </Match>
+    <Match>
+        <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>   
+    </Match>
+    <Match>
+        <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>    
+    </Match>
+    <Match>
+        <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>    
     </Match>
 </FindBugsFilter>
diff --git a/andmore-core/plugins/logger/findbugsExclusion.xml b/andmore-core/plugins/logger/findbugsExclusion.xml
@@ -3,8 +3,14 @@
 
     <Match>
         <Bug pattern="VA_FORMAT_STRING_USES_NEWLINE" />
-        <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>
-        <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>
-        <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>
+    </Match>
+    <Match>
+        <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>   
+    </Match>
+    <Match>
+        <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>    
+    </Match>
+    <Match>
+        <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>    
     </Match>
 </FindBugsFilter>
diff --git a/andmore-core/plugins/mat/findbugsExclusion.xml b/andmore-core/plugins/mat/findbugsExclusion.xml
@@ -3,8 +3,14 @@
 
     <Match>
         <Bug pattern="VA_FORMAT_STRING_USES_NEWLINE" />
-        <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>
-        <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>
-        <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>
+    </Match>
+    <Match>
+        <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>   
+    </Match>
+    <Match>
+        <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>    
+    </Match>
+    <Match>
+        <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>    
     </Match>
 </FindBugsFilter>
diff --git a/andmore-core/plugins/packaging.ui/findbugsExclusion.xml b/andmore-core/plugins/packaging.ui/findbugsExclusion.xml
@@ -3,8 +3,14 @@
 
     <Match>
         <Bug pattern="VA_FORMAT_STRING_USES_NEWLINE" />
-        <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>
-        <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>
-        <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>
+    </Match>
+    <Match>
+        <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>   
+    </Match>
+    <Match>
+        <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>    
+    </Match>
+    <Match>
+        <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>    
     </Match>
 </FindBugsFilter>
diff --git a/andmore-core/plugins/remote.device/findbugsExclusion.xml b/andmore-core/plugins/remote.device/findbugsExclusion.xml
@@ -3,8 +3,14 @@
 
     <Match>
         <Bug pattern="VA_FORMAT_STRING_USES_NEWLINE" />
-        <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>
-        <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>
-        <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>
+    </Match>
+    <Match>
+        <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>   
+    </Match>
+    <Match>
+        <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>    
+    </Match>
+    <Match>
+        <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>    
     </Match>
 </FindBugsFilter>
diff --git a/andmore-core/plugins/snippets/findbugsExclusion.xml b/andmore-core/plugins/snippets/findbugsExclusion.xml
@@ -3,8 +3,14 @@
 
     <Match>
         <Bug pattern="VA_FORMAT_STRING_USES_NEWLINE" />
-        <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>
-        <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>
-        <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>
+    </Match>
+    <Match>
+        <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>   
+    </Match>
+    <Match>
+        <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>    
+    </Match>
+    <Match>
+        <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>    
     </Match>
 </FindBugsFilter>
diff --git a/andmore-core/plugins/translation/findbugsExclusion.xml b/andmore-core/plugins/translation/findbugsExclusion.xml
@@ -3,8 +3,14 @@
 
     <Match>
         <Bug pattern="VA_FORMAT_STRING_USES_NEWLINE" />
-        <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>
-        <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>
-        <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>
+    </Match>
+    <Match>
+        <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>   
+    </Match>
+    <Match>
+        <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>    
+    </Match>
+    <Match>
+        <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>    
     </Match>
 </FindBugsFilter>
diff --git a/android-core/plugins/org.eclipse.andmore.base/findbugsExclusion.xml b/android-core/plugins/org.eclipse.andmore.base/findbugsExclusion.xml
@@ -3,8 +3,14 @@
 
     <Match>
         <Bug pattern="VA_FORMAT_STRING_USES_NEWLINE" />
-        <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>
-        <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>
-        <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>
+    </Match>
+    <Match>
+        <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>   
+    </Match>
+    <Match>
+        <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>    
+    </Match>
+    <Match>
+        <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>    
     </Match>
 </FindBugsFilter>
diff --git a/android-core/plugins/org.eclipse.andmore.ddms/findbugsExclusion.xml b/android-core/plugins/org.eclipse.andmore.ddms/findbugsExclusion.xml
@@ -3,8 +3,14 @@
 
     <Match>
         <Bug pattern="VA_FORMAT_STRING_USES_NEWLINE" />
-        <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>
-        <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>
-        <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>
+    </Match>
+    <Match>
+        <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>   
+    </Match>
+    <Match>
+        <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>    
+    </Match>
+    <Match>
+        <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>    
     </Match>
 </FindBugsFilter>
diff --git a/android-core/plugins/org.eclipse.andmore.gldebugger/findbugsExclusion.xml b/android-core/plugins/org.eclipse.andmore.gldebugger/findbugsExclusion.xml
@@ -3,8 +3,14 @@
 
     <Match>
         <Bug pattern="VA_FORMAT_STRING_USES_NEWLINE" />
-        <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>
-        <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>
-        <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>
+    </Match>
+    <Match>
+        <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>   
+    </Match>
+    <Match>
+        <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>    
+    </Match>
+    <Match>
+        <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>    
     </Match>
 </FindBugsFilter>